-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up order stuff #1362
Fix up order stuff #1362
Conversation
#1344 has been merged into |
@rmunn oh, right. That was a bit silly of me. But, my changes are fairly small, so I'm not worried. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll take a deeper look once develop has been merged in
63f169e
to
617d644
Compare
C# Unit Tests104 tests +1 104 ✅ +1 5s ⏱️ ±0s Results for commit b998f1b. ± Comparison against base commit a8d082f. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
|
b998f1b
to
68b6d99
Compare
Sad story:
I'm not sure how we want to approach that, but to avoid being stuck behind an open PR, I've drastically reduced this PR to simply add something that was forgotten and remove the validation that was already in place. I've moved other things to this branch: feat/1246-move-order-validation-to-fluent-validation_old |
I don't want to add more validation in the wrong place, so I've gone ahead and moved the validation that I already added.