Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up order stuff #1362

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Jan 10, 2025

I don't want to add more validation in the wrong place, so I've gone ahead and moved the validation that I already added.

@rmunn
Copy link
Contributor

rmunn commented Jan 10, 2025

#1344 has been merged into develop now, so you might get some merge conflicts here.

@myieye
Copy link
Contributor Author

myieye commented Jan 10, 2025

@rmunn oh, right. That was a bit silly of me. But, my changes are fairly small, so I'm not worried.
Good job getting that merged in!

Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll take a deeper look once develop has been merged in

backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs Outdated Show resolved Hide resolved
Base automatically changed from feat/1246-allow-reordering-example-sentences to develop January 13, 2025 14:49
@myieye myieye force-pushed the feat/1246-move-order-validation-to-fluent-validation branch from 63f169e to 617d644 Compare January 13, 2025 14:59
@myieye myieye marked this pull request as ready for review January 13, 2025 15:08
Copy link

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit b998f1b. ± Comparison against base commit a8d082f.

Copy link

C# Unit Tests

104 tests  +1   104 ✅ +1   5s ⏱️ ±0s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit b998f1b. ± Comparison against base commit a8d082f.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
Testing.LexCore.Services.FwLiteReleaseServiceTests ‑ CanGetLatestRelease
Testing.LexCore.Services.FwLiteReleaseServiceTests ‑ CanGetLatestRelease(platform: Linux)
Testing.LexCore.Services.FwLiteReleaseServiceTests ‑ CanGetLatestRelease(platform: Windows)

@myieye myieye force-pushed the feat/1246-move-order-validation-to-fluent-validation branch from b998f1b to 68b6d99 Compare January 15, 2025 11:56
@myieye myieye changed the title Move order validation to FluentValidation Fix up order stuff Jan 15, 2025
@myieye
Copy link
Contributor Author

myieye commented Jan 15, 2025

Sad story:

  • Excluding Order from JSON in the Web version doesn't seem to be working anymore 🤷
  • It's not actually even set up for Maui and I don't think it's really possible. We'd have to use a JsonConverter instead and I fought with that for a long time before I found the current way of doing it.

I'm not sure how we want to approach that, but to avoid being stuck behind an open PR, I've drastically reduced this PR to simply add something that was forgotten and remove the validation that was already in place.

I've moved other things to this branch: feat/1246-move-order-validation-to-fluent-validation_old
I don't think a PR makes sense at this point, because it's a bit of a mess.
One of the things in there is the validation that I/we added to the BulkCreateEntries method. It's actually very unclear to me if we want that and I lost your changes @hahn-kev and couldn't find them in my reflog, but I think I managed to reproduce them. I know...this is very chaotic.

@myieye myieye merged commit d0e337d into develop Jan 15, 2025
13 checks passed
@myieye myieye deleted the feat/1246-move-order-validation-to-fluent-validation branch January 15, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants